Skip to content

DPE-4273 avoid restart being triggered after upgrade#451

Merged
paulomach merged 1 commit intomainfrom
fix/dpe-4273-override-config-on-upgrade
May 6, 2024
Merged

DPE-4273 avoid restart being triggered after upgrade#451
paulomach merged 1 commit intomainfrom
fix/dpe-4273-override-config-on-upgrade

Conversation

@paulomach
Copy link
Copy Markdown

Issue

  • on upgrade, config file was not being update/override in the process
  • after updgrade, config change was triggering restart of the service
  • restart hook failed to consider all units

This was causing the failure of scaling up after a successful upgrade.

Solution

  • addressed issues above

Copy link
Copy Markdown

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also tested locally, cannot reproduce DPE-4273 anymore. Tnx!

@paulomach paulomach merged commit 19633f3 into main May 6, 2024
@paulomach paulomach deleted the fix/dpe-4273-override-config-on-upgrade branch May 6, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants