core: add DisplayInfo::physical_address

[saviq-work]

What's new?

DisplayInfo::physical_address

How to test

Tests.

Checklist

• Tests added and pass
• Adequate documentation added
• (optional) Added Screenshots or videos

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[Copilot]

Copilot review overview

🟡 Changes recommended

The libmircore4 Debian symbols manifest is missing after the ABI bump.

Review effort: Lite
Findings: 1

Open (1)

• Missing Debian symbols file for libmircore4 ABI · New

What changed in this PR

Adds HDMI physical-address parsing to DisplayInfo, with unit tests and Mir Core ABI/package updates.

Changes:

• Parses CTA HDMI vendor blocks.
• Adds DisplayInfo::physical_address and test coverage.
• Bumps the Mir Core ABI and packaging metadata.

File	Summary
tests/​unit-tests/​graphics/​test_display_configuration.cpp	Adds EDID parsing tests.
src/​core/​graphics/​display_configuration.cpp	Parses HDMI physical addresses.
src/​core/​CMakeLists.txt	Bumps the ABI; moderate issue (1 vote): add/update debian/libmircore4.symbols.
rpm/​mir.spec	Updates RPM SONAME metadata.
include/​core/​mir/​graphics/​display_configuration.h	Adds physical_address.
debian/​libmircore4.install	Installs the new SONAME.
debian/​libmircore3.install	Removes the old SONAME installation.
debian/​control	Updates the Debian package; moderate issue (3 votes): add/update the missing symbols manifest.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[mattkae]

Cool 🫘

[AlanGriffiths]

There's no need to bump the mircore ABI - DisplayInfo is only in the 2.31 stanza

[github-actions]

TICS Quality Gate

✔️ Passed

mir

Coding Standards: ✔️ Passed

✔️ Condition “No new Coding Standard Violations for level 1, 2, 3 with respect to Previous analysis” passed.

See the results in the TICS Viewer

The following files have been checked for this project

• include/core/mir/graphics/display_configuration.h
• src/core/graphics/display_configuration.cpp

TICS / TICS / Run TICS analysis

[saviq-work]

There's no need to bump the mircore ABI - DisplayInfo is only in the 2.31 stanza

Ah! Forgot we're only now moving it into core 🍾.

[AlanGriffiths]

[out of scope] but I'm not sure how a uint16_t can represent a physical_address

[saviq-work]

[out of scope] but I'm not sure how a uint16_t can represent a physical_address

@copilot please explain in a comment to this PR.

[Copilot]

[out of scope] but I'm not sure how a uint16_t can represent a physical_address

@copilot please explain in a comment to this PR.

physical_address is the HDMI/EDID topology address, not a byte-addressable memory location. HDMI encodes it in a 16-bit field as four 4-bit path components (commonly displayed in dotted form, e.g. 1.2.0.0), with zero components marking the end of the path. That is why uint16_t is the appropriate representation here.