Skip to content

coding guildelines: update to clarify use of implementation inheritance #5236

Description

@AlanGriffiths

Part of the guideline says "If you want to do private inheritance, you should be including an instance of the base class as a member instead". I suspect this was written in a context that no longer applies (language features and design idioms have changed).

The discussion of interface inheritance seems reasonable enough. But the choice to ban implementation inheritance is naive. This is, I think, a case where there is a clear benefit to implementation inheritance using a private base class. We should update the guidelines to cover such cases.

Originally posted by @AlanGriffiths in #5194 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    DocumentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions