-
Notifications
You must be signed in to change notification settings - Fork 13
Draft PR for cherry-pick #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mvlassis
wants to merge
12
commits into
track/2.4
Choose a base branch
from
manos-cherry-pick
base: track/2.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Add Prometheus alert rules * Fix tabs in Prometheus alert rules * Update alert rules * Update KFP_File_Descriptiors_Exhausted to use seconds * Specify kfp-api charm in alert rules * Update operators in alerts
Move charms deployed during tests to a separate file called charms_dependencies.py. This enables programmatic access to them and thus updating them centrally, probably with the use of `kfcicli`. This uses `CharmSpec` dataclass from chisme to define dependency charms as separate objects. Also, a helper function enables generating context for cases where a bundle.yaml is used during tests. Ref canonical/bundle-kubeflow/issues/1256
Closes #698 Note that we're also pinning the version of cosl>=0.0.48 due to canonical/bundle-kubeflow#1260
* Add dashboard * Change name * Change title * Update dashboard * Update dashboard * Update dashboard * Update dashboard * Update dashboard * Update dashboard * Update dashboard
…723) * chore: update charmcraft for charm kfp_api * chore: update dependecies for charm kfp_api * chore: update charmcraft for charm kfp_metadata_writer * chore: update dependecies for charm kfp_metadata_writer * chore: update charmcraft for charm kfp_persistence * chore: update dependecies for charm kfp_persistence * chore: update charmcraft for charm kfp_profile_controller * chore: update dependecies for charm kfp_profile_controller * chore: update charmcraft for charm kfp_schedwf * chore: update dependecies for charm kfp_schedwf * chore: update charmcraft for charm kfp_ui * chore: update dependecies for charm kfp_ui * chore: update charmcraft for charm kfp_viewer * chore: update dependecies for charm kfp_viewer * chore: update charmcraft for charm kfp_viz * chore: update dependecies for charm kfp_viz * chore: remove unnecessary Python requirement constraints * ci: use Ubuntu's default Python * chore: replace older Ubuntu versions with the newer one * chore: replace deprecated imports with up-to-date ones * ci: avoid caching builds across different charms * fix: restore accidentally unstaged file path in Charmcraft * chore: upgrade charmed-kubeflow-chisme after upstream bugfix * docs: link issues instead of pull requests and dicussions * ci: set Python up explicitly * chore: upgrade Python-setup action * docs: fix URL typo * test: rely on existing bases until newer bases published * style: remove outdated comment
* chore: upgrade Ubuntu for testing utilities relying on newer charm bases * chore: unpin direct dependency for further upgrades on newer Ubuntu versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.