Add slices for bash and coreutils #61
Conversation
slices/bash.yaml
Outdated
| - libtinfo6_libs | ||
| contents: | ||
| /bin/bash: | ||
| /bin/sh: { symlink: /bin/bash } |
There was a problem hiding this comment.
Hmm.. this is a tricky one. We should have a symlink to /bin/bash, but perhaps including this in contents might be a bad idea. Because, chisel does not support conflicting paths across slices/packages, yet. See canonical/chisel#50.
So I am worried including /bin/sh might raise this issue. For example, if we were to install dash and then create a symlink in a same way, we will have conflicts.
So, perhaps, it's better to drop this from the contents, at least for now. We could leave a comment/note to remind ourselves that we need to do this manually after installation.
There was a problem hiding this comment.
Agreed, removed the /bin/sh from contents and added a comment.
| /usr/bin/join: | ||
| /usr/bin/link: | ||
| /usr/bin/logname: | ||
| /usr/bin/md5sum: |
There was a problem hiding this comment.
/usr/bin/md5sum.textutils seems to be missing.
slices/coreutils.yaml
Outdated
| /usr/bin/who: | ||
| /usr/bin/whoami: | ||
| /usr/bin/yes: | ||
| /usr/libexec/coreutils/libstdbuf.so: |
There was a problem hiding this comment.
I think this should be in a libs slice.You can then add that slices as an essential in the bins slice.
There was a problem hiding this comment.
I'm uncertain if we should place this library in a separate libs section. It appears to be an internal library for coreutils and isn't meant for external use.
There was a problem hiding this comment.
It appears to be an internal library for
coreutilsand isn't meant for external use.
True. But typically we group the libraries (including internal ones) into libs and binaries into bins for better categorization.
There was a problem hiding this comment.
Make sense, updated, thanks!
| essential: | ||
| - libc6_libs | ||
| contents: | ||
| /lib/*-linux-*/libtinfo.so.6*: |
There was a problem hiding this comment.
Perhaps we should add /usr/lib/*-linux-*/libtic.so.6* as done in https://github.com/canonical/chisel-releases/blob/ubuntu-20.04/slices/libtinfo6.yaml.
slices/coreutils.yaml
Outdated
| /usr/bin/link: | ||
| /usr/bin/logname: | ||
| /usr/bin/md5sum: | ||
| /usr/bin/md5sum.textutils: { symlink: /usr/bin/md5sum } |
There was a problem hiding this comment.
SInce this already comes as a symlink from the package, you don't need to manually create it.
| /usr/bin/md5sum.textutils: { symlink: /usr/bin/md5sum } | |
| /usr/bin/md5sum.textutils: |
slices/coreutils.yaml
Outdated
| /usr/bin/who: | ||
| /usr/bin/whoami: | ||
| /usr/bin/yes: | ||
| /usr/libexec/coreutils/libstdbuf.so: |
There was a problem hiding this comment.
It appears to be an internal library for
coreutilsand isn't meant for external use.
True. But typically we group the libraries (including internal ones) into libs and binaries into bins for better categorization.
|
@woky will you please take a look at this PR? |
Co-authored-by: Cristovao Cordeiro <[email protected]>
--------- Co-authored-by: Cristovao Cordeiro <[email protected]>
--------- Co-authored-by: Cristovao Cordeiro <[email protected]>
This pull request introduces slice definitions for bash and GNU coreutils, along with some associated libraries.