[DPE-3196] Add integration test for Apache Iceberg integration #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theoctober19th
changed the title
welpaolo
previously approved these changes
Jan 31, 2024
deusebio
previously approved these changes
Jan 31, 2024
There was a problem hiding this comment.
LGTM! I don't have any objection and changes seem sensible.
I'd rather merge this PR and after the re-structuring of the tests (PR #68 ) to then make sure things work with restrictred account. Also, it is a bit of a consideration, but I feel that the integration tests files is becoming huge (which is good because we are running more and more tests... :D). But I believe we could improve a bit the current integration tests by creating more maintainable and perimetered files.
theoctober19th
dismissed stale reviews from deusebio and welpaolo
via
1da1160
welpaolo
previously approved these changes
Feb 1, 2024
welpaolo
approved these changes
Feb 1, 2024
deusebio
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds integration tests to verify integration of Apache Iceberg in Charmed Spark solution.
Jira:
DPE-3196