Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-3104] Create Jupyter notebook image #62

Conversation

deusebio
Copy link
Contributor

@deusebio deusebio commented Dec 11, 2023

This PR re-integrates jupyter (that is integrated with spark) that was removed from the image in #57, but in a dedicated image. I have also updated the CI pipeline such that when we release the base image, we also release the jupyter one.

I have discussed offline with @cjdcordeiro to make sure that the name of the image, charmed-spark-jupyterlab4:3.4-22.04_edge makes sense and it is sound.

@cjdcordeiro
Copy link

cjdcordeiro commented Dec 12, 2023

just to recap, the other option would be something like charmed-spark3.4-jupyterlab:4. I actually prefer that one, just because the image's entrypoint is jupyter, and thus it is more intuitive for the oci tag to reflect the entrypoint app's version.

Having said that, given that the rock comprises 2 main application components, I'll let you decide on what best fits your use case.

welpaolo
welpaolo previously approved these changes Jan 3, 2024
Copy link
Collaborator

@welpaolo welpaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@deusebio
Copy link
Contributor Author

deusebio commented Jan 8, 2024

I have been discussing this topic offline with @cjdcordeiro and @kimwnasptd. In the case of compounded images (e.g. as in this case where we do have multiple components), each with its version, we came up with a couple of options for naming schemes to deal with this, that are summarized below. These options are meant to confirm with the current standard of naming tags of images with

<appVersion>-<base>_<risk>

Let's say that we have an image with 3 components, and respective versions: app-X.x , foo-Y.y and bar-Z.z. Two possible naming schemes are:

  • app-fooY.y-barZ.z:X.x-base_risk
  • app-foo-bar:X.x-Y.y-Z.z-base_risk

We would generally be inclined to go with the first, as this would provide clearer information about which app the appVersion refers to.

@deusebio deusebio changed the base branch from 3.4-22.04/edge to dpe-3104-jupyterlab-image February 1, 2024 16:30
@deusebio deusebio merged commit 53c2f88 into canonical:dpe-3104-jupyterlab-image Feb 1, 2024
7 checks passed
@deusebio deusebio deleted the dpe-3104-jupyter-image branch February 1, 2024 16:34
deusebio pushed a commit to deusebio/charmed-spark-rock that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants