-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-3104] Create Jupyter notebook image #62
[DPE-3104] Create Jupyter notebook image #62
Conversation
just to recap, the other option would be something like Having said that, given that the rock comprises 2 main application components, I'll let you decide on what best fits your use case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I have been discussing this topic offline with @cjdcordeiro and @kimwnasptd. In the case of compounded images (e.g. as in this case where we do have multiple components), each with its version, we came up with a couple of options for naming schemes to deal with this, that are summarized below. These options are meant to confirm with the current standard of naming tags of images with
Let's say that we have an image with 3 components, and respective versions:
We would generally be inclined to go with the first, as this would provide clearer information about which app the |
3073393
to
c5b1ab4
Compare
feat: add trivyignore to mimir
This PR re-integrates jupyter (that is integrated with spark) that was removed from the image in #57, but in a dedicated image. I have also updated the CI pipeline such that when we release the base image, we also release the jupyter one.
I have discussed offline with @cjdcordeiro to make sure that the name of the image,
charmed-spark-jupyterlab4:3.4-22.04_edge
makes sense and it is sound.