-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-17353 Refresh home page #360
base: main
Are you sure you want to change the base?
Conversation
templates/index.html
Outdated
</tr> | ||
<tr> | ||
<th><strong>Android versions</strong></th> | ||
<td data-heading="Appliance">10, 11, 12, 13</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be 12, 13 and 14 as covered in the copy doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated 👍
4586c6b
to
29fa765
Compare
Hey @mattea-turic, the page is ready to review. Could I get a design review please? 🙏 A demo link is here: https://anbox-cloud-io-360.demos.haus/ |
Thank you @minkyngkm ! Pretty much perfect: For the testimonials section:
I'll add a +1 ! |
Thanks @mattea-turic, done! 👍 |
Hi @minkyngkm, there are a few small items including: |
Thanks @Sophie-32 for your review. I've applied your suggestions. Hope it looks better now! |
{{ image ( | ||
url="https://assets.ubuntu.com/v1/8b62755e-equinix-logo-vw.png", | ||
alt="Equinix logo", | ||
width="80", | ||
height="100", | ||
hi_def=True, | ||
loading="lazy" | ||
) | safe | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattea-turic I couldn't find this image in the Figma file from the asset server. I used the same logo from the logo section above but resized it to make it smaller. Would this be okay?
@minkyngkm I apologize I think I was unclear:
Let me know if either of those is unclear |
Thank you @Sophie-32 🙏 All images showed alt to me so I didn't make any changes to the alts |
Thanks @minkyngkm - commenting in place of Sophie while she's away. I can't seem to view the demo now but I think Sophie was suggesting to remove the alt text and replace it with alt=' '. Since the images are decorative, alt text is not necessary for screen readers. Thank you for your help on this! |
@eliman11 Thanks, I've removed the alt texts for the decorative images. Demo should be working at https://anbox-cloud-io-360.demos.haus/ 🙏 |
Looks great, thank you for the revisions! Adding UX+1 |
Done
Refresh
index.html
QA
Issue / Card
Fixes #https://warthogs.atlassian.net/browse/WD-17353