Clean up some old habits, fix couple of lint issues

canelmas · Sep 3, 2017 · 65afb39 · 65afb39
1 parent 39616d0
commit 65afb39
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 29 deletions.
diff --git a/let-runtime/src/main/java/com/canelmas/let/DelayedTasks.java b/let-runtime/src/main/java/com/canelmas/let/DelayedTasks.java
@@ -16,6 +16,8 @@
 
 package com.canelmas.let;
 
+import android.annotation.SuppressLint;
+
 import org.aspectj.lang.ProceedingJoinPoint;
 
 import java.util.Collections;
@@ -24,11 +26,9 @@
 import java.util.Map;
 import java.util.concurrent.Callable;
 
-/**
- * Created by can on 27/10/15.
- */
-public final class DelayedTasks {
+final class DelayedTasks {
 
+    @SuppressLint("UseSparseArrays")
     private static Map<Integer, Task> tasks = Collections.synchronizedMap(new HashMap<Integer, Task>());
 
     static Task get(final int requestCode) {

diff --git a/let-runtime/src/main/java/com/canelmas/let/DeniedPermission.java b/let-runtime/src/main/java/com/canelmas/let/DeniedPermission.java
@@ -16,9 +16,6 @@
 
 package com.canelmas.let;
 
-/**
- * Created by can on 21/10/15.
- */
 public final class DeniedPermission {
 
     final String permission;

diff --git a/let-runtime/src/main/java/com/canelmas/let/Let.java b/let-runtime/src/main/java/com/canelmas/let/Let.java
@@ -22,9 +22,6 @@
 import java.util.ArrayList;
 import java.util.List;
 
-/**
- * Created by can on 31/08/15.
- */
 public final class Let {
 
     /**

diff --git a/let-runtime/src/main/java/com/canelmas/let/LetAspect.java b/let-runtime/src/main/java/com/canelmas/let/LetAspect.java
@@ -22,9 +22,6 @@
 import org.aspectj.lang.annotation.Around;
 import org.aspectj.lang.annotation.Aspect;
 
-/**
- * Created by can on 31/08/15.
- */
 @Aspect
 public final class LetAspect {
 

diff --git a/let-runtime/src/main/java/com/canelmas/let/LetContext.java b/let-runtime/src/main/java/com/canelmas/let/LetContext.java
@@ -16,13 +16,11 @@
 
 package com.canelmas.let;
 
+import android.annotation.SuppressLint;
 import android.app.Activity;
 import android.app.Fragment;
 import android.support.v4.app.ActivityCompat;
 
-/**
- * Created by can on 30/10/15.
- */
 public final class LetContext {
 
     private final Object source;
@@ -31,7 +29,8 @@ public LetContext(final Object source) {
         this.source = source;
     }
 
-    public void requestPermissions(String[] permissions, int requestCode) {
+    @SuppressLint("NewApi")
+    void requestPermissions(String[] permissions, int requestCode) {
 
         if (source instanceof Activity) {
 
@@ -49,7 +48,7 @@ public void requestPermissions(String[] permissions, int requestCode) {
 
     }
 
-    public Activity getActivity() {
+    Activity getActivity() {
 
         if (source instanceof Activity) {
 

diff --git a/let-runtime/src/main/java/com/canelmas/let/LetException.java b/let-runtime/src/main/java/com/canelmas/let/LetException.java
@@ -16,9 +16,6 @@
 
 package com.canelmas.let;
 
-/**
- * Created by can on 27/09/15.
- */
 final class LetException extends RuntimeException {
 
     public LetException(String detailMessage) {

diff --git a/let-runtime/src/main/java/com/canelmas/let/RuntimePermissionListener.java b/let-runtime/src/main/java/com/canelmas/let/RuntimePermissionListener.java
@@ -18,9 +18,6 @@
 
 import java.util.List;
 
-/**
- * Created by can on 22/10/15.
- */
 public interface RuntimePermissionListener {
 
     void onShowPermissionRationale(final List<String> permissionList, final RuntimePermissionRequest permissionRequest);

diff --git a/let-runtime/src/main/java/com/canelmas/let/RuntimePermissionRequest.java b/let-runtime/src/main/java/com/canelmas/let/RuntimePermissionRequest.java
@@ -29,17 +29,14 @@
 import java.util.List;
 import java.util.concurrent.atomic.AtomicInteger;
 
-/**
- * Created by can on 07/10/15.
- */
 public final class RuntimePermissionRequest {
 
     private static final AtomicInteger PERMISSIONS_REQUEST_CODE = new AtomicInteger();
 
     final Object source;
     final ProceedingJoinPoint joinPoint;
 
-    public RuntimePermissionRequest(ProceedingJoinPoint joinPoint, Object source) {
+    RuntimePermissionRequest(ProceedingJoinPoint joinPoint, Object source) {
         this.source = source;
         this.joinPoint = joinPoint;
     }
@@ -48,7 +45,7 @@ public void retry() {
         proceed(true);
     }
 
-    protected Object proceed() {
+    Object proceed() {
         return proceed(false);
     }