Draft
Conversation
The term 'sitelib' is used for locations where pure-Python modules are installed, and 'sitearch' is where Python extension modules (written in C or C++) are. eg., Fedora uses the RPM macros python3_sitelib and python3_sitearch [1]. In this case, the PYTHON_SITELIB build flag was being used to denote the 'sitearch' location because it was being assigned the value of Fedora's python_sitearch. Therefore, rename PYTHON_SITELIB as PYTHON_SITEARCH to make the name of the flag match its purpose. Fallout from f445b64 [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
The location specified by the DNF_PLUGIN_PYTHON_SITELIB build flag was not specific to DNF plugins. It was the top-level 'sitelib' location where pure-Python modules are installed. Therefore, rename the flag as PYTHON_SITELIB to make the name of the flag match its purpose. Fallout from 5e488ac
debarshiray
force-pushed
the
wip/rishi/cloud-what-noarch
branch
from
360aca4 to
5653f4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...