feat(settings): move logo.dev into Providers as an API integration#1922
Merged
Conversation
Reframe the Providers tab to cover all pluggable APIs, not just bank-data providers, and relocate the logo.dev brand-logo settings (the counterparty logos toggle + publishable token) out of General → Counterparties into a new 'API integrations' section there. logo.dev now reads as a directory row (image icon · name · on/off status · chevron) that opens a config drawer — matching the bank-provider rows — so the tab is a uniform directory of services you plug in. The drawer holds the enable toggle and token (both auto-saving via settings.js to the existing 204 endpoints) plus an info note about the domain-restricted-key referrer gotcha (a restricted key needs this instance's domain in its allowed referrers, wildcard included) — the exact 401 a user just hit. The two config keys + POST endpoints are unchanged; only where they render moves. ProvidersProps gains CounterpartyLogos/LogoDevToken (populated from the existing CounterpartyLogoSettings); SettingsProps sheds the now-unused fields. General loses the Counterparties section. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012fRHZ1CTjEZ1xFwQmW27jU
Owner
Author
|
@claude remove the banner alert about "domain-restricted". |
|
Claude finished @canalesb93's task in 9m 29s —— View job Removing domain-restricted banner alert
Removed the Commit: |
…awer Co-authored-by: Ricardo Canales <canalesb93@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reframes the Providers tab to cover all pluggable APIs — not just bank-data providers — and relocates the logo.dev brand-logo settings there from General → Counterparties.
Why
The Providers tab was bank-only, while logo.dev (counterparty brand logos) lived in a small General → Counterparties section. logo.dev is an external API you plug in, so it belongs with the providers — and the tab can grow into a directory of every API integration.
What changed
imageicon · name · on/off status · chevron — that opens a config drawer, exactly like the bank-provider rows. The tab now reads as one uniform directory of services you plug in.settings.jsto the existing 204 endpoints — verified working on this tab) and an info note about the domain-restricted-key referrer gotcha: a restricted key needs this instance's domain in its allowed referrers (wildcard included), else logo.dev 401s and logos fall back to monograms. That's the exact issue surfaced in support recently, now documented in-product.ProvidersPropsgainsCounterpartyLogos/LogoDevToken(from the existingCounterpartyLogoSettings);SettingsPropssheds the now-unused fields.No new config keys, endpoints, or schema — only where the controls render moves. Default/headless/lite builds +
go vet+ admin/templates unit tests green.Providers tab
logo.dev config drawer
🤖 Generated with Claude Code