fix(rules): move the "Retroactive" marker inline into the transaction subtitle#1921
Merged
Conversation
The rule-detail "Recent Applications" list floated a "RETROACTIVE" label in a full-width strip above each transaction row, which added an awkward extra line and read as disconnected from the row it described (#1917). Move the marker inline into the transaction's meta (subtitle) line, next to the account/category, as a compact muted chip. The shared TxRow gains an optional `WithMetaBadge` option (variadic, so all ~50 existing callers are unchanged) that renders a caller-supplied chip at the tail of the meta line. The rule-detail page passes a "⏪ Retroactive" chip for non-sync applications. Below the `sm` breakpoint the label collapses to just the icon (with a tooltip) so the cramped mobile sub-line doesn't truncate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J9FhcQJ7yrrbT1rzRAzkKv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1917.
Problem
On the rule-detail page (
/rules/{id}), the Recent Applications list rendered theRETROACTIVElabel as a full-width strip floating in the top-right above each transaction row. That added an awkward extra line and read as disconnected from the row it describes — the spacing looked off, as called out in the issue.Change
Move the marker inline into the transaction's meta (subtitle) line, right after the account/category, as a compact muted chip (⏪ Retroactive) — matching how the row already surfaces tags, comments, and flags.
TxRowcomponent gains an optional, variadicWithMetaBadgeoption, so all ~50 existing call sites stay unchanged (zero options) — only the rule-detail list passes a badge.syncapplications;sync(the default firing path) stays unlabeled, exactly as before.smbreakpoint the cramped mobile sub-line would truncate the word, so the label collapses to just the icon (with atitletooltip); the desktop meta line always shows the full label.The old floating strip is removed. The rule's action itself is still described once in the Then card above, so it isn't repeated per row.
Validation
Built +
go vetclean;templ generateregenerated; touched-package tests pass (internal/templates/...,internal/admin,internal/service). Validated in a real browser against a seeded rule with 4 retroactively-applied transactions.Screenshots
RETROACTIVEfloating top-right (from issue [Task] Move the "Retroactive" indicator inline with the transaction #1917): https://bb-artifacts.exe.xyz/f/df4ec00fd3a14dd7.jpg🤖 Generated with Claude Code
https://claude.ai/code/session_01J9FhcQJ7yrrbT1rzRAzkKv