fix(feed): drop redundant added/modified breakdown from sync rows - #1911
Merged
Conversation
The sync event headline already states the primary count ("1 new
transaction", "5 transactions updated"), so repeating it as a
"• 1 added • 1 modified" chip row directly below is redundant noise.
Remove the added/modified/removed chips from feedSyncBody. The trigger
context (manual run / webhook / first sync) is NOT in the headline, so
it stays — now on its own gated line without the orphaned leading
separator.
Closes #1910
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013p9DKQtNfzb4Jjsu2KXsYB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1910.
What
In the home timeline feed (
/), each sync row showed an added/modified chip breakdown ("• 1 added • 1 modified") directly under the headline. The headline already states the primary count — "1 new transaction", "3 transactions updated", "2 transactions removed" — so repeating it as chips is redundant noise.This is the issue's exact ask: "we don't need to show added / modified as generally the event title has enough context."
Change
feedSyncBodyininternal/templates/components/pages/feed.templ:manual run,webhook,first sync) — that is not in the headline, so it is genuinely additive. It now renders on its own gated line, without the orphaned leading separator it used to inherit from the chip row./logs/sync-logs/{id}), and the sample-transaction list below each row is untouched.Net diff: 7 insertions, 13 deletions, one file.
Evidence
Captured at the issue's mobile viewport (402px wide, dark). Seed data covers every case: added+modified (the exact screenshot from the issue), added-only, modified-only + webhook trigger, and added+removed + manual trigger.
(Screenshots are linked rather than inlined — this PR is authored through an API layer that strips inline image embeds; the links open the JPEGs directly.)
1 added / 1 modifiedchips under each headline: https://bb-artifacts.exe.xyz/f/9534bf143f36c349.jpgwebhook/manual runtrigger labels preserved: https://bb-artifacts.exe.xyz/f/9ffbfdc706519f4f.jpgThe two red "Sync failed … unknown provider: teller" rows at the top of the captures are an artifact of the seed connections (no real Teller provider in the dev box) — unrelated to this change.
Validation
templ generate+go build ./...+go vet ./internal/templates/...— all clean.