Skip to content

feat(feed): collapse per-rule list into a sync-log summary #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canalesb93 merged 1 commit into from
Jun 24, 2026
Merged

feat(feed): collapse per-rule list into a sync-log summary #1908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions internal/templates/components/pages/feed.templ
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,27 +554,10 @@ templ feedSyncBody(it FeedItem, s *FeedSync, now time.Time) {
</div>
}
if len(s.RuleOutcomes) > 0 {
<div class="mt-1 flex items-center gap-1.5 flex-wrap text-base-content/55">
<a href={ templ.SafeURL("/logs/sync-logs/" + s.SyncLogID) } class="mt-1 inline-flex items-center gap-1.5 text-base-content/55 hover:text-primary transition-colors no-underline">
@components.LucideIcon("zap", "w-3 h-3 text-primary opacity-70")
for i, ro := range s.RuleOutcomes {
if i > 0 {
<span class="text-base-content/25">·</span>
}
if ro.RuleShortID != "" {
<a href={ templ.SafeURL("/rules/" + ro.RuleShortID) } class="hover:text-primary transition-colors no-underline">
<span class="font-medium text-base-content/85">{ feedNonEmpty(ro.RuleName, "A rule") }</span>
<span>&nbsp;applied to&nbsp;</span>
<span class="font-medium tabular-nums text-base-content/85">{ fmt.Sprintf("%d", ro.Count) }</span>
</a>
} else {
<span>
<span class="font-medium text-base-content/85">{ feedNonEmpty(ro.RuleName, "A rule") }</span>
<span>&nbsp;applied to&nbsp;</span>
<span class="font-medium tabular-nums text-base-content/85">{ fmt.Sprintf("%d", ro.Count) }</span>
</span>
}
}
</div>
<span class="font-medium text-base-content/85">{ feedRuleSummaryText(s.RuleOutcomes) }</span>
</a>
}
}

Expand Down Expand Up @@ -1046,6 +1029,21 @@ func feedNonEmpty(a, fallback string) string {
return fallback
}

// feedRuleSummaryText renders the one-line rule-application summary shown on
// a sync card — e.g. "3 rules applied · 12 hits". The per-rule breakdown
// (which rule, how many each) lives on the sync-log detail page that the
// summary links to, so the feed stays a glanceable headline.
func feedRuleSummaryText(outcomes []FeedRuleOutcome) string {
rules := len(outcomes)
total := 0
for _, o := range outcomes {
total += o.Count
}
return fmt.Sprintf("%d %s applied · %d %s",
rules, pluralLabel("rule", rules != 1),
total, pluralLabel("hit", total != 1))
}

// feedDisplayName resolves the preferred display label for a feed tx ref:
// the assigned counterparty's name when present, otherwise the caller's
// provider/merchant fallback. Mirrors the COALESCE(counterparty_name, ...)
Expand Down
Loading