-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(devin): recover oversized prompt history after rejection #6014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+375
−8
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4999f38
fix(devin): recover oversized prompt history after rejection
riverpilot 48a93ee
fix(devin): gate recovery on shrinkable history size
riverpilot a898f6d
fix(devin): count trailing tool output for context overflow detection
riverpilot cc3b201
fix(devin): exclude entire contiguous active user/developer tail from…
riverpilot dcb0423
fix(devin): type assistant tool-call fixture for overflow recovery
riverpilot 9cc82b1
fix(devin): retain flushed history in overflow sizing
riverpilot bf0f690
docs(ai): move Devin recovery note to unreleased
riverpilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fresh remaining active-tail case is when the same prompt ends with another user-role companion: this backward scan is skipped unless the final role is
developer, but#promptWithMessagecan append same-turn messages after the prompt (e.g. file mentions aftermessages.push(message)inpackages/coding-agent/src/session/agent-session.ts:8876-8892), and image file mentions convert torole: "user"inpackages/coding-agent/src/session/messages.ts:845-872. For a huge current user prompt followed by a small user companion, the huge live prompt is counted inshrinkablePrompts, so the opaque Devin rejection is mislabeled asContextOverflowand sent through compaction even though that active tail cannot be shrunk.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Investigated against the existing regression suite. The history contains indistinguishable consecutive user-role records: flushed prior execution history must remain compactable, while same-turn user companions must be excluded. Without an active-turn boundary in the Message/Context contract, excluding every trailing user record breaks the prior-history regression and misclassifies large flushed execution output. The current implementation preserves that safety invariant; this finding needs an explicit active-turn boundary before it can be implemented without regressing the earlier P1/P2 fixes.