Skip to content

fix(coding-agent): resolve thinking level overrides in temporary model switcher #5291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PGupta-Git wants to merge 2 commits into
base: main
Choose a base branch
from
+30 −2
Open

fix(coding-agent): resolve thinking level overrides in temporary model switcher #5291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c28eed
fix(coding-agent): resolve thinking level overrides in temporary mode…
PGupta-Git Jul 12, 2026
e5624e0
fix(coding-agent): extend thinking override lookup to custom roles
PGupta-Git Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/coding-agent/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Fixed

- Fixed the temporary model selector (`Alt+P` / `/switch` / `/model --temporary`) ignoring custom role-specific thinking level overrides from `config.yml` (e.g. `:high`), reverting to the model's native default level instead
- Improved search reliability for Perplexity provider by forcing retrieval for all queries
- Fixed JS eval cells losing top-level `function` and `var` declarations across cells when the defining cell contained top-level `await` — the async wrapper scoped them to the cell's IIFE instead of publishing them to the worker global

Expand Down
31 changes: 29 additions & 2 deletions packages/coding-agent/src/modes/controllers/selector-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,12 @@ import {
resolveAdvisorConfigEditPath,
saveWatchdogConfigFile,
} from "../../advisor";
import { formatModelSelectorValue, resolveAdvisorRoleSelection } from "../../config/model-resolver";
import {
formatModelSelectorValue,
getModelMatchPreferences,
resolveAdvisorRoleSelection,
resolveModelRoleValue,
} from "../../config/model-resolver";
import { getRoleInfo } from "../../config/model-roles";
import { settings } from "../../config/settings";
import { disableProvider, enableProvider } from "../../discovery";
Expand Down Expand Up @@ -688,8 +693,30 @@ export class SelectorController {
},
onPick: async (model, selector) => {
try {
// Resolve configured thinking level from settings roles if it matches this model
const availableModels = this.ctx.session.modelRegistry.getAvailable();
const matchPreferences = getModelMatchPreferences(this.ctx.settings);
let resolvedThinkingLevel: ConfiguredThinkingLevel | undefined;

for (const [, roleModelStr] of Object.entries(this.ctx.settings.getModelRoles())) {

@roboomp roboomp Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking: MODEL_ROLE_IDS contains only the ten built-in roles, while Settings.getModelRoles() may contain custom roles and getKnownRoleIds(settings) is the existing enumeration that includes them. A model assigned only as modelRoles.critic: …:high therefore never reaches this loop, so the temporary picker still falls back to the model default. Please resolve across the known/configured roles rather than the static built-in list; merged PR #5297 does this in AgentSession.resolveTemporaryModelThinkingLevel().

const resolved = resolveModelRoleValue(roleModelStr, availableModels, {
settings: this.ctx.settings,
matchPreferences,
});
if (
resolved.model &&
resolved.model.provider === model.provider &&
resolved.model.id === model.id
) {
if (resolved.explicitThinkingLevel && resolved.thinkingLevel !== undefined) {
resolvedThinkingLevel = resolved.thinkingLevel;
break;
}
}
}

// Session-only: update agent state but don't persist the model to settings.
await this.ctx.session.setModelTemporary(model);
await this.ctx.session.setModelTemporary(model, resolvedThinkingLevel);
this.ctx.statusLine.invalidate();
this.ctx.updateEditorBorderColor();
const roleSelectorHint = this.ctx.keybindings.getKeys("app.model.select")[0] ?? "Alt+M";
Expand Down