fix(tool): support Codex web search GPT-5.6 Responses-Lite models#5288
Open
roboomp wants to merge 1 commit into
Open
fix(tool): support Codex web search GPT-5.6 Responses-Lite models#5288roboomp wants to merge 1 commit into
roboomp wants to merge 1 commit into
Conversation
- Added GPT-5.6 Luna, Terra, and Sol to the Codex web-search default model preference chain. - Encoded catalogued Responses-Lite Codex web-search requests with developer additional_tools, compatibility metadata, and the lite header while keeping classic models on the existing shape. - Covered default fallback, explicit override, Responses-Lite shape, and reasoning-effort suffix behavior. Fixes #5286
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro
With
PI_CODEX_WEB_SEARCH_MODEL=gpt-5.6-luna, a mockedsearchCodexcall againstpackages/coding-agent/src/web/search/providers/codex.tscaptured a/backend-api/codex/responsesrequest that still had top-leveltools,tool_choice, andinstructions, beganinputwith the user message, and omittedx-openai-internal-codex-responses-lite: true. The default model preference chain also started atgpt-5.5, so default Codex web search never tried Luna, Terra, or Sol first.Cause
packages/coding-agent/src/web/search/providers/codex.tshard-codedDEFAULT_MODEL_PREFERENCESto GPT-5.5-and-older models and built one classic Responses request body incallCodexSearchfor every model. The provider never consulted bundled Codex model metadata, souseResponsesLite: trueon the GPT-5.6 catalog entries could not affect request encoding.Fix
PI_CODEX_WEB_SEARCH_MODELrequests, including validated<model>:<effort>suffixes.useResponsesLitemodels to developeradditional_tools, developer instructions, Responses-Lite headers, Codex compatibility metadata, andreasoning.context=all_turns; classic models keep the existing top-leveltools,tool_choice, andinstructionsshape.packages/coding-agent/CHANGELOG.mdentry for the fix.Verification
bun test packages/coding-agent/test/tools/web-search-codex.test.tspassed: 14 pass, 0 fail, 54 expect() calls.bun run check:tspassed across the TypeScript workspaces.bun checkfails onmainfor an unrelated Rust formatting diff incrates/pi-ast/src/ops.rs;git diff --name-only origin/main..HEAD -- crates/pi-ast/src/ops.rsis empty, so the pre-publish gate was skipped. Fixes #5286