-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: rename /model slash command to /models #5273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,11 +17,11 @@ function createRuntime() { | |
| }; | ||
| } | ||
|
|
||
| describe("/model slash command", () => { | ||
| describe("/models slash command", () => { | ||
| it("opens the model setup picker for role and thinking assignment", async () => { | ||
| const harness = createRuntime(); | ||
|
|
||
| const handled = await executeBuiltinSlashCommand("/model", harness.runtime); | ||
| const handled = await executeBuiltinSlashCommand("/models", harness.runtime); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should-fix: This only proves the new |
||
|
|
||
| expect(handled).toBe(true); | ||
| expect(harness.showModelSelector.mock.calls).toEqual([[]]); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking: This drops the only
/modelregistration (BUILTIN_SLASH_COMMAND_LOOKUPis populated only fromnameplusaliasesat lines 2296-2300), so existing TUI and ACP invocations of/modelnow fall through. The repo bar says default-behavior changes need explicit maintainer sign-off; absent that, make/modelscanonical but keepaliases: ["model"]so existing user scripts/docs keep working.