-
Notifications
You must be signed in to change notification settings - Fork 226
feat(webmodeler): H2, MariaDB and MySQL configuration #7208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(webmodeler): H2, MariaDB and MySQL configuration #7208
Conversation
|
👋 🤖 🤔 Hello, @christinaausley! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.8/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
9487a8f to
10db9b8
Compare
docs/self-managed/components/modeler/web-modeler/configuration/database.md
Outdated
Show resolved
Hide resolved
|
@camunda/tech-writers, I did not add the Also, could you take a look if the @aleksander-dytko, I added you like last time as reviewer to make sure I didn't oversee anything. @Szik, I also added you for the setup part, because I got the test setup from you and reused some of it and I know it can be improved. |
|
@christinaausley I've assigned to you for review as I think this probably relates to your database docs work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just two minor comments.
docs/self-managed/components/modeler/web-modeler/configuration/configuration.md
Outdated
Show resolved
Hide resolved
docs/self-managed/components/modeler/web-modeler/configuration/configuration.md
Outdated
Show resolved
Hide resolved
10db9b8 to
4992039
Compare
docs/self-managed/components/modeler/web-modeler/configuration/database.md
Outdated
Show resolved
Hide resolved
docs/self-managed/components/modeler/web-modeler/configuration/database.md
Outdated
Show resolved
Hide resolved
docs/self-managed/components/modeler/web-modeler/configuration/database.md
Outdated
Show resolved
Hide resolved
docs/self-managed/components/modeler/web-modeler/configuration/database.md
Outdated
Show resolved
Hide resolved
docs/self-managed/components/modeler/web-modeler/configuration/database.md
Outdated
Show resolved
Hide resolved
docs/self-managed/components/modeler/web-modeler/configuration/database.md
Outdated
Show resolved
Hide resolved
docs/self-managed/components/modeler/web-modeler/configuration/database.md
Outdated
Show resolved
Hide resolved
docs/self-managed/components/modeler/web-modeler/configuration/database.md
Outdated
Show resolved
Hide resolved
docs/self-managed/components/modeler/web-modeler/configuration/database.md
Outdated
Show resolved
Hide resolved
docs/self-managed/components/modeler/web-modeler/configuration/database.md
Outdated
Show resolved
Hide resolved
docs/self-managed/components/modeler/web-modeler/configuration/database.md
Outdated
Show resolved
Hide resolved
docs/self-managed/components/modeler/web-modeler/configuration/database.md
Outdated
Show resolved
Hide resolved
docs/self-managed/components/modeler/web-modeler/configuration/database.md
Outdated
Show resolved
Hide resolved
|
@JacobiCamunda I'll give this a final review after comments are resolved from @Szik to avoid making things messy 👍 |
|
@christinaausley, I addressed all comments from @Szik. You can give your final review. @aleksander-dytko, feel free to also add your feedback. If not, the PR is ready to merge after I then addressed @christinaausley's comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JacobiCamunda Feel free to review my latest commit with all of my adjustments and let me know if you have questions 🚀
|
The preview environment relating to the commit 45f97e6 has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-7208/ |
Description
Closes https://github.com/camunda/web-modeler/issues/18465
When should this change go live?
This is a bug fix, security concern, or something that needs urgent release support. (addbugorsupportlabel)This is already available but undocumented and should be released within a week. (addavailable & undocumentedlabel)This is on a specific schedule and the assignee will coordinate a release with the Documentation team. (create draft PR and/or addholdlabel)There is no urgency with this change (addlow priolabel)PR Checklist
{type}(scope): {description}commit message(s)/docsdirectory (version8.88.9).My changes are for an already released minor and are in a/versioned_docsdirectory.@camunda/tech-writersunless working with an embedded writer.