Ver todos carros disponíveis na tela inicial - #8
Open
campuscode-par01 wants to merge 5 commits into
Open
Conversation
campuscode-par01
changed the title
campuscode-par01
changed the title
campuscode-par01
changed the title
joaorsalmeida
requested changes
Aug 15, 2019
| @@ -1,13 +1,7 @@ | |||
| <h1>Detalhes do Veículo</h1> | |||
| <dl> | |||
| <strong><dt>Modelo do Veículo</dt></strong> | |||
Contributor
There was a problem hiding this comment.
Me parece meio brusca essa mudança ^^
Acredito que outros testes vão quebrar nas demais branches, talvez fosse uma boa alinhar com todo time
| @@ -0,0 +1 @@ | |||
| <%= render @cars %> No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Poderia ter um titulo nessa tela
campuscode-par01
changed the title
joaorsalmeida
requested changes
Aug 19, 2019
| create_list(:car, 5, status: :available, car_model: create(:car_model, name: 'Palio')) | ||
| create_list(:car, 5, status: :on_maintenance, car_model: create(:car_model, name: 'Palio')) | ||
|
|
||
| cars = Car.last_available_cars |
Contributor
There was a problem hiding this comment.
Falta nesse teste garantir que os carros devolvidos estao corretos. O teste só garante que temos 5 itens na lista.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User Story:
Como usuário de uma filial,
Gostaria de ver os últimos 10 carros disponíveis na tela inicial,
Para ficar mais fácil a minha visualização dos carros disponíveis. 🚗
Feature adicional
Deve existir uma opção para ver todos os carros
Link da tarefa:
https://trello.com/c/KoyAnCRf/26-ver-todos-carros-dispon%C3%ADveis-na-tela-inicial