This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Don't allow users to edit anything if there's no editable layer visible #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (layers.hasOwnProperty(i)) { | ||
| size++; | ||
| this.getAttributesStore(layers[i].attributes.layer_id, null, function(store, geometryType) { | ||
| menu.add(this.createMenuItem(layers[i], geometryType)); |
There was a problem hiding this comment.
This is suspicious. I think that the value of i will be the same for every load callback. Relying Ext.each should be an easy way to fix that.
added 6 commits
March 27, 2012 13:23
…ts items to appear several times in the menu.
|
It looks good. Thanks. |
added 2 commits
March 28, 2012 13:34
…editable layers changes.
| newFeatureBtn.setText(newFeatureBtn.initialConfig.text); | ||
| } | ||
| if (this.editorGrid && | ||
| this.editorGrid.store.feature.attributes.__layer_id__.toString() == item.layerId) { |
There was a problem hiding this comment.
I think toString isn't necessary.
|
I've added a few comments. After that you can merge if the tests continue to pass. |
pgiraud
pushed a commit
that referenced
this pull request
Mar 28, 2012
Don't allow users to creating new features on not-visible layers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.