Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG]Added test case for method bbox_no_intersection from utils to check no intersection logic #252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rahul-bhave
Copy link
Contributor

@rahul-bhave rahul-bhave commented Jul 9, 2021

This PR contains the test case written to test the logic for method def bbox_intersection_area(ba, bb) from utils when no intersecting area is available.[line 403 and 404 from the utils.py]

Below is the test run output

$ python setup.py -v test
running pytest
running egg_info
writing camelot_py.egg-info\PKG-INFO
writing dependency_links to camelot_py.egg-info\dependency_links.txt
writing entry points to camelot_py.egg-info\entry_points.txt
writing requirements to camelot_py.egg-info\requires.txt
writing top-level names to camelot_py.egg-info\top_level.txt
'license_file' option was not specified
reading manifest file 'camelot_py.egg-info\SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'camelot_py.egg-info\SOURCES.txt'
running build_ext
============================= test session starts =============================
platform win32 -- Python 3.8.2, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 -- C:\Users\XXXXX\XXXXX\XXXXX\camelot\venv3\Scripts\python.exe
cachedir: .pytest_cache
Matplotlib: 3.4.2
Freetype: 2.6.1
rootdir: C:\Users\XXXXX\XXXXX\XXXXX\camelot, configfile: setup.cfg
plugins: cov-2.12.1, mock-3.6.1, mpl-0.13
collecting ... collected 65 items

tests/test_utils.py::test_bbox_intersection_text PASSED                  [100%]

@rahul-bhave rahul-bhave changed the title Added test case for method bbox_no_intersection from utils to check no intersection logic [MRG]Added test case for method bbox_no_intersection from utils to check no intersection logic Jul 9, 2021
@rahul-bhave
Copy link
Contributor Author

@rahul-bhave
Copy link
Contributor Author

##76

changed the test name to be more aligned with other tests
@rahul-bhave rahul-bhave force-pushed the test_utils_bbbox_no_intersection_area branch from 4cc95b8 to 82d0bf2 Compare July 12, 2021 06:42
@MartinThoma
Copy link
Collaborator

Hey!

As camelot is dead, we try to build a maintained fork at pypdf_table_extraction.

Do you want to open the PR against that branch so that we can merge your improvement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants