Skip to content

Conversation

@Ishneet0710
Copy link
Collaborator

Summary

  • Fixes combobox click to return the updated combobox ref in diffSnapshot
  • When clicking a combobox, the ref may change after click (DOM re-render)
  • Now finds the new ref by aria-label or [expanded] state and prepends it to diffSnapshot

Test plan

  • Tested with Google Flights combobox
  • Verified diffSnapshot now includes combobox line with new ref

Closes #3471

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 3, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/combobox-click-return-updated-ref

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Review Required PR need to be reviewed label Dec 3, 2025
Copy link
Collaborator

@YunfeiZHAO YunfeiZHAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Just in viewport mode, it may include elements outside the viewport in diffsnapshot, but it is not import for my point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Required PR need to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Browser refine combobox click return

5 participants