change proto generation to specify explicit ordering of codegen to en…#1445
Open
matthewpeterkort wants to merge 1 commit into
Open
change proto generation to specify explicit ordering of codegen to en…#1445matthewpeterkort wants to merge 1 commit into
matthewpeterkort wants to merge 1 commit into
Conversation
…able deterministic proto gen so that developers know when the proto has actually changed. Add support for submodule intialization in proto-depends
Gen3 Integration Tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, proto-depends did not initialize the sub-module that the TES generation references so make gen would error after make proto in a fresh repo. I have added this to the makefile so that users do not trip on this gotcha in the future.
Also, proto codegen used to non-deterministically generate proto. This is annoying because as a developer you want to know for sure if proto has changed or not and the old setup would generate structs in random order so it was unclear whether there was a material change in the structs or not.