Language Improvements #13
Conversation
keertyverma
left a comment
keertyverma
left a comment
There was a problem hiding this comment.
Added few comments. Let me know your thoughts.
Thank you.
| if(!this._isValidLanguage(language)) { | ||
| // If invalid language, fallback to plain text | ||
| this.data.language = 'plain'; | ||
| this.data.editorInstance.updateLanguage('none'); | ||
| this._element.querySelector('.editorjs-codeCup_LangDisplay').innerHTML = 'none'; | ||
| this._handleErrorMessage(language); // Show error message | ||
| return false; | ||
| } |
There was a problem hiding this comment.
-
While this approach prevents invalid syntax highlighting, it may negatively impact the user experience by removing their last valid selection.
Would it be better to retain the previously valid language and syntax highlighter instead? This would help ensure users don’t lose their last selection due to an unintended input error.
if(!this._isValidLanguage(language)) {
this._handleErrorMessage(language); // Show an error message for the invalid language
return false;
}- Additionally, if we still want to reset the language to plain text, the language display text should also reflect Plain Text rather than showing none for consistency.
| static getDefaultLanguages() { | ||
| return { | ||
| bash: "Bash", | ||
| c: "C", | ||
| cpp: "C++", | ||
| csharp: "C#", | ||
| css: "CSS", | ||
| go: "Go", | ||
| html: "HTML", | ||
| java: "Java", | ||
| javascript: "JavaScript", | ||
| json: "JSON", | ||
| kotlin: "Kotlin", | ||
| none: "Plain Text", | ||
| php: "PHP", | ||
| python: "Python", | ||
| ruby: "Ruby", | ||
| rust: "Rust", | ||
| sql: "SQL", | ||
| swift: "Swift", | ||
| typescript: "TypeScript", | ||
| }; | ||
| } |
| padding-left: 10px; | ||
| padding-right: 10px; | ||
| right: 0; | ||
| right: 0px; |
There was a problem hiding this comment.
If right: 0px is used, the language display name may not be shown properly when a scrollbar is present.
In my PR, I have adjusted this to right: 12px to ensure proper visibility.
|
|
||
| .editorjs-codeCup_languageDropdown { | ||
| /* top:10px; left:100px; */ | ||
| position: fixed; |
There was a problem hiding this comment.
With position:fixed the dropdown is cropped off in mobile devices. Would you be able to retain my changes?
position: absolute;
top: 100%;
left: 0;
Includes Improvements from @keertyverma and @calumk