Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve naming in a backward compatible way #69

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

mdjastrzebski
Copy link
Member

Summary

Improve naming:

  • notDigit => nonDigit
  • notWord => nonWord
  • notWhitespace => nonWhitespace
  • notWordBoundary => nonWordBoundary
  • inverted => negated

Previous names to be still available with @deprecated notice.

Test plan

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (39f4cda) to head (ab9c462).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #69   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          168       173    +5     
  Branches        39        39           
=========================================
+ Hits           168       173    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdjastrzebski mdjastrzebski merged commit b72a125 into main Mar 27, 2024
4 checks passed
@mdjastrzebski mdjastrzebski deleted the feat/improve-naming branch March 27, 2024 11:54
@mdjastrzebski
Copy link
Member Author

Released in v1.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants