feat: anyOf component
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 8 +2
Lines 59 68 +9
Branches 8 11 +3
=========================================
+ Hits 59 68 +9 ☔ View full report in Codecov by Sentry. |
mdjastrzebski
force-pushed
the
feat/any-of
branch
from
4500f2a to
9e02622
Compare
mdjastrzebski
force-pushed
the
feat/any-of
branch
from
9e02622 to
43007de
Compare
mdjastrzebski
force-pushed
the
feat/any-of
branch
from
658f174 to
8531994
Compare
okwasniewski
approved these changes
Dec 12, 2023
| // See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_expressions/Character_classes#types | ||
| function escapeHypen(characters: string[]) { | ||
| if (characters.includes('-')) { | ||
| return ['-', ...characters.filter((c) => c !== '-')]; |
There was a problem hiding this comment.
Shouldn't this function also call .join() and return a string?
There was a problem hiding this comment.
Not yet, it is parsing it's input for RegexElement. Join will be done when we will compile it. We want to keep these as array of strings, as character class may hold e.g. \\d. \\u1234 which are two+ chars, but one conceptual char.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #6
Test plan
Added relevant tests