feat: repeat quantifier
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okwasniewski
force-pushed
the
feat/repeat
branch
from
c71de78 to
1f876cb
Compare
okwasniewski
force-pushed
the
feat/repeat
branch
from
1f876cb to
6dd5e9a
Compare
okwasniewski
force-pushed
the
feat/repeat
branch
from
6dd5e9a to
5af1f2d
Compare
src/quantifiers/repeat.ts
Outdated
| config: Repeat['config'] | ||
| ): string { | ||
| if ('count' in config && typeof config?.count === 'number') { | ||
| return `${wrapGroup(compiledChildren)}{${config?.count || ''}}`; |
There was a problem hiding this comment.
[nit] Why || ''? You should be able to access config.count directly inside the if.
mdjastrzebski
requested changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements
repeat()utility. I still need to figure out how to properly type itTest plan
Passings tests