feat: choiceOf component
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjastrzebski
force-pushed
the
feat/choice-of
branch
3 times, most recently
from
1b29711 to
f3d87a7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
===========================================
+ Coverage 97.95% 100.00% +2.04%
===========================================
Files 5 6 +1
Lines 49 57 +8
Branches 7 8 +1
===========================================
+ Hits 48 57 +9
+ Misses 1 0 -1 ☔ View full report in Codecov by Sentry. |
mdjastrzebski
force-pushed
the
feat/choice-of
branch
2 times, most recently
from
7ad70c6 to
5bddb8c
Compare
mdjastrzebski
changed the title
choiceOf componentchoiceOf component
mdjastrzebski
force-pushed
the
feat/choice-of
branch
from
6336227 to
f7645ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added
choiceOfcomponent implementing the alternative (|) operator. This is a very powerful operator, as it can be applied to simple text as well as nested regex expressions. Due to it's very low priority, the passed options needs to be wrapped in group in most cases.Resolves #4
Test plan
Added relevant tests.