Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include @rspack/react-refresh-plugin with Re.Pack #810

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Dec 4, 2024

Summary

Closes #804

@rspack/react-refresh-plugin is now included in Re.Pack instead of being a peer dependcy since it's used in both webpack and rspack variants

Test plan

n/a

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 32b6f63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@callstack/repack Minor
@callstack/repack-init Minor
@callstack/repack-dev-server Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 10:14am

@hosseinmd
Copy link
Contributor

also @rspack/core should be installed

@jbroma
Copy link
Member Author

jbroma commented Dec 5, 2024

also @rspack/core should be installed

there shouldn't be a need to do that, can you show me an example where that's the problem?

@jbroma
Copy link
Member Author

jbroma commented Dec 5, 2024

just tested on fresh project with webpack - there are no errors related to @rspack/core missing 🤷

@jbroma jbroma requested a review from thymikee December 6, 2024 08:38
@jbroma jbroma changed the title refactor: add @rspack/react-refresh-plugin to Re.Pack deps feat: include @rspack/react-refresh-plugin with Re.Pack Dec 6, 2024
@jbroma jbroma merged commit 46330d7 into main Dec 6, 2024
5 checks passed
@jbroma jbroma deleted the refactor/include-react-refresh-plugin branch December 6, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repack v5 by webpack need to install rspack
3 participants