Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add transform react jsx automatic to node module rules #808

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Dec 4, 2024

Summary

This PR fixes the discrepancy between Re.Pack default module transform rules and the official RN Babel preset.

swc uses classic runtime transform, while RN babel preset uses automatic JSX transform so we need to declare runtime: 'automatic' explicitly for the node module rules.

Test plan

  • - testers work

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 8f8cb4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@callstack/repack Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Dec 4, 2024 6:43pm

@jbroma jbroma merged commit f600e07 into main Dec 4, 2024
5 checks passed
@jbroma jbroma deleted the fix/include-jsx-transform branch December 4, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant