Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: better logger #1727

Merged
merged 2 commits into from
Jan 8, 2025
Merged

chore: better logger #1727

merged 2 commits into from
Jan 8, 2025

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented Jan 8, 2025

Summary

Use own logger, as console.log etc logged very verbose messages which included stacktrace, etc.

Before:
CleanShot 2025-01-08 at 09 44 17@2x

After:
CleanShot 2025-01-08 at 09 43 56@2x

Test plan

Manually test logger output on sample inputs like, strings, arrays, objects, etc.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 15 lines in your changes missing coverage. Please review.

Project coverage is 95.43%. Comparing base (f8a0d44) to head (e59f2c7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/helpers/logger.ts 56.25% 14 Missing ⚠️
src/queries/make-queries.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1727      +/-   ##
==========================================
- Coverage   95.70%   95.43%   -0.27%     
==========================================
  Files          91       92       +1     
  Lines        5076     5107      +31     
  Branches      879      880       +1     
==========================================
+ Hits         4858     4874      +16     
- Misses        218      233      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdjastrzebski mdjastrzebski merged commit b4d5942 into main Jan 8, 2025
7 of 8 checks passed
@mdjastrzebski mdjastrzebski deleted the chore/logger branch January 8, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant