Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note user.scrollTo in favour of fireEvent.scroll and edit broken links #1551

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

vanGalilea
Copy link
Contributor

Summary

  • Clarify that the User Event API is more reliable than the Fire Event API as its more suitable for RN env simulation.
  • Fix broken links to code base

Test plan

  • review changed content
  • double check that the links now work

relates to #1549

Future improvements

  • support scroll to the bottom of a VirtualizedList

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21254b0) 95.40% compared to head (068be8f) 95.51%.
Report is 1 commits behind head on main.

❗ Current head 068be8f differs from pull request most recent head 5ee74aa. Consider uploading reports for the commit 5ee74aa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1551      +/-   ##
==========================================
+ Coverage   95.40%   95.51%   +0.11%     
==========================================
  Files          99       99              
  Lines        5400     5400              
  Branches      858      857       -1     
==========================================
+ Hits         5152     5158       +6     
+ Misses        248      242       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pierrezimmermannbam pierrezimmermannbam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @vanGalilea! I appreciate you're taking some time to improve the docs and also fix broken links! You'll need an approve from another maintainer before this gets merged though

website/docs/API.md Outdated Show resolved Hide resolved
@mdjastrzebski mdjastrzebski merged commit 3e2060d into callstack:main Jan 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants