Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disable React 17 tests on CI, as they were always failing due to snapshot miss match as well of some unsupported features like the new ARIA props. On the other hand the way the test script has been written quietly consumed this failure, so that React 17 tests always indicated success.
I've tried to disable just this tests on the CI but could not overcome following error (local & CI):
React 17 tests could still be run locally using
yarn test:react-17
script.Test plan