Skip to content

FIX: Props containing "key" prop is being spread into JSX #4563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ChromeQ
Copy link

@ChromeQ ChromeQ commented Nov 25, 2024

Destructure the key and pass it directly to the Touchable component to resolve error

Related issue

Fixes #4562

Test plan

I struggled to get react-native or expo upgraded to the latest versions in the example folder as it is quite out of date. Please see issue to understand the error thrown by react-native 0.76

@callstack-bot
Copy link

Hey @ChromeQ, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@kyng-cytro
Copy link

Is this going to be merged? Or is there a workaround?

@ChromeQ
Copy link
Author

ChromeQ commented Dec 8, 2024

Hey @kyng-cytro, unfortunately it doesn't look like it as there are other PR's waiting a long time, I recommend checking out patch-package to workaround for yourself, and the best thing is that if/when it does get fixed patch-package will tell you and you simply delete the patch file.

rsmidt added a commit to rsmidt/soccerbuddy that referenced this pull request Dec 18, 2024
@Steven-MKN
Copy link

This lib is getting annoying to work with, and PRs that resolve issues are not merged, or at least they don't get any feedback

@ChromeQ
Copy link
Author

ChromeQ commented Feb 11, 2025

Actually, turns out this change was merged (although not in isolation or from an existing PR) I will close this now as it is no longer needed and I can confirm it works without warning on the latest version.

77d3af7#diff-54d07d0dd9a891cd54e08e7642d895b92a592e9294af566460fa17dab475fa0eL363

@ChromeQ ChromeQ closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: Props containing "key" prop is being spread into JSX
4 participants