Skip to content

Conversation

@shovel-kun
Copy link
Contributor

@shovel-kun shovel-kun commented Oct 31, 2024

@okwasniewski
Copy link
Member

Hey! Thanks for working on this

FYI there is a guide on how to do this: https://reactnavigation.org/docs/7.x/custom-navigators/

I need to check how can we handle the breaking change

@matinzd
Copy link

matinzd commented Nov 10, 2024

I suggest creating a separate file for version 7 to maintain support for version 6. By default, we can keep version 6 support, and selectively import the new React Navigation v7 integration, for example:

// This will be compatible with v7
import {createNativeBottomTabNavigator} from 'react-native-bottom-tabs/react-navigation/v7';

// This will be compatible with v6
import {createNativeBottomTabNavigator} from 'react-native-bottom-tabs/react-navigation';

Or we can do it the other way around and introduce a breaking change version to set v7 as default.

WDYT? @okwasniewski

@okwasniewski
Copy link
Member

Here is first PR that moves us in the direction of supporting React Navigation v7:

#152

It introduces a separate package for the integration: @bottom-tabs/react-navigation which will be released as 0.6.0, then in 0.7.0 the support for React Navigation v6 will be dropped but people will still be able to use @bottom-tabs/[email protected] for React navigation v6, this will allow smoother migration to React Navigation v7 and doesn't bring the maintenance cost of supporting two versions indefinitely

@shovel-kun shovel-kun closed this Nov 18, 2024
@shovel-kun
Copy link
Contributor Author

Closing as there's a better PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants