Skip to content

fix(android): invalidate mask bitmap for descendant updates #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddx533534 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(android): invalidate mask bitmap for descendant updates #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions android/src/main/java/org/reactnative/maskedview/RNCMaskedView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import android.graphics.PorterDuff;
import android.graphics.PorterDuffXfermode;
import android.view.View;
import android.view.ViewParent;

import com.facebook.react.views.view.ReactViewGroup;

Expand Down Expand Up @@ -52,10 +53,11 @@ public void onDescendantInvalidated(View child, View target) {

if (!mBitmapMaskInvalidated) {
View maskView = getChildAt(0);
if (maskView != null) {
if (maskView.equals(child)) {
mBitmapMaskInvalidated = true;
}
// OEM-specific invalidation propagation may report either the direct mask child
// or a deeper descendant here, so invalidate the cached bitmap for the whole
// mask subtree rather than only for the direct child.
if (maskView != null && isDescendantOfMaskView(maskView, child)) {
mBitmapMaskInvalidated = true;
}
}

Expand Down Expand Up @@ -109,4 +111,16 @@ public static Bitmap getBitmapFromView(final View view) {
public void setRenderingMode(String renderingMode) {
mRenderingMode = renderingMode.equals("software") ? View.LAYER_TYPE_SOFTWARE : View.LAYER_TYPE_HARDWARE;
}

private boolean isDescendantOfMaskView(View maskView, View child) {
View current = child;
while (current != null) {
if (current == maskView) {
return true;
}
ViewParent parent = current.getParent();
current = parent instanceof View ? (View) parent : null;
}
return false;
}
}