feat: Enable @react-native/platform-colors rule#275
Merged
Conversation
thymikee
reviewed
Jun 10, 2024
| plugins: ['react-native'], | ||
| plugins: ['react-native', '@react-native'], | ||
| rules: { | ||
| '@react-native/platform-colors': WARNING, |
Member
There was a problem hiding this comment.
can we turn on all recommended rules?
Contributor
Author
There was a problem hiding this comment.
@react-native plugin is exported only one rule )
thymikee
reviewed
Jun 10, 2024
thymikee
reviewed
Jun 10, 2024
Comment on lines
+5
to
+9
| PlatformColor(); // required at least one argument | ||
| // eslint-disable-next-line @react-native/platform-colors | ||
| PlatformColor([], {}); // arguments must be string literals | ||
| // eslint-disable-next-line @react-native/platform-colors | ||
| DynamicColorIOS('red'); // required object as first argument |
Member
There was a problem hiding this comment.
tbh looks like TS should take care of these
Contributor
Author
There was a problem hiding this comment.
of course TS will catch it early
but it still useful for JS projects
thymikee
approved these changes
Jun 10, 2024
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Member
|
Published in v14.2.0. Next time please use "squash and merge" instead of just merging, it helps me keep the commit history tidy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@react-native/platform-colorsruleTest plan
see:
test/PlatformColor.js