Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tests for no-constant-binary-expression #270

Merged

Conversation

retyui
Copy link
Contributor

@retyui retyui commented Nov 9, 2023

Summary

Add test for no-constant-binary-expression rule

Test plan

// comment out `'no-constant-binary-expression': ERROR,` in `node.js`
yarn test
// ^^^ should fail with the next errors:
//  - `Unused eslint-disable directive (no problems were reported from 'no-constant-binary-expression')`

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One example of correct and incorrect would be just enough, can you reduce it? 🙏🏼

@retyui retyui force-pushed the chore/retyui/add-test-for-no-constant-binary-expression-rule branch from 304d532 to fa10d60 Compare November 9, 2023 15:40
@retyui retyui requested a review from thymikee November 9, 2023 15:41
@retyui
Copy link
Contributor Author

retyui commented Nov 9, 2023

One example of correct and incorrect would be just enough, can you reduce it? 🙏🏼

no problem

@thymikee thymikee merged commit ac4bb1c into main Nov 9, 2023
@thymikee thymikee deleted the chore/retyui/add-test-for-no-constant-binary-expression-rule branch November 9, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants