chore: cr fixes

callstack · Dec 5, 2024 · ccbd1c8 · ccbd1c8
1 parent cea9c91
commit ccbd1c8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 17 deletions.
diff --git a/.changeset/cuddly-mangos-train.md b/.changeset/cuddly-mangos-train.md
@@ -3,4 +3,4 @@
 'discord-example': minor
 ---
 
-added start function to abstract away passing bot token
+changed passing bot token variable and discord login
diff --git a/examples/discord/src/index.ts b/examples/discord/src/index.ts
@@ -29,12 +29,11 @@ const app = createApp({
 
 const discordClient = await createDiscordApp({
   app,
-  botToken: DISCORD_BOT_TOKEN,
 });
 
 void (async () => {
   try {
-    await discordClient.start();
+    await discordClient.login(DISCORD_BOT_TOKEN);
     logger.info('Discord ready.');
   } catch (error) {
     logger.error('Dev Slack start error:', error);

diff --git a/packages/discord/src/index.ts b/packages/discord/src/index.ts
@@ -6,17 +6,10 @@ const UPDATE_THROTTLE_TIME = 200;
 
 export type DiscordApplicationConfig = {
   app: Application;
-  botToken: string;
 };
 
-type ClientStart = {
-  start: () => Promise<string>;
-};
-
-export type DiscordClient = Client & ClientStart;
-
-export function createDiscordApp(options: DiscordApplicationConfig): DiscordClient {
-  const { app, botToken } = options;
+export function createDiscordApp(options: DiscordApplicationConfig) {
+  const { app } = options;
 
   const client = new Client({
     intents: [
@@ -26,7 +19,7 @@ export function createDiscordApp(options: DiscordApplicationConfig): DiscordClie
       GatewayIntentBits.GuildMessages,
     ],
     partials: [Partials.Channel],
-  }) as DiscordClient;
+  });
 
   client.once(Events.ClientReady, (readyClient) => {
     console.log(`Ready! Logged in as ${readyClient.user.tag}`);
@@ -82,10 +75,6 @@ export function createDiscordApp(options: DiscordApplicationConfig): DiscordClie
     await pendingEffects;
   });
 
-  client.start = () => {
-    return client.login(botToken);
-  };
-
   return client;
 }