fix(struct): encode false and null fields correctly (#4)

callmehiphop · Aug 8, 2019 · 55f7bea · 55f7bea
1 parent 18ff5f9
commit 55f7bea
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/index.ts b/index.ts
@@ -128,7 +128,7 @@ export const struct = {
     const fields = {};
     Object.keys(json).forEach(key => {
       // If value is undefined, do not encode it.
-      if (!json[key]) return;
+      if (typeof json[key] === 'undefined') return;
       fields[key] = value.encode(json[key]);
     });
     return {fields};

diff --git a/test.ts b/test.ts
@@ -5,12 +5,14 @@ const arr = [null, 10];
 
 const obj = {
   foo: 'bar',
-  yes: true
+  no: false,
+  nil: null
 };
 
 const objWithUndefined = {
   foo: 'bar',
-  yes: true,
+  no: false,
+  nil: null,
   isUndefined: undefined
 };
 
@@ -30,9 +32,13 @@ const structValue = {
       kind: 'stringValue',
       stringValue: 'bar'
     },
-    yes: {
+    no: {
       kind: 'boolValue',
-      boolValue: true
+      boolValue: false
+    },
+    nil: {
+      kind: 'nullValue',
+      nullValue: 0
     }
   }
 };