Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: layout of dialog (edit location) on bookings page #20268

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

krakenftw
Copy link
Contributor

@krakenftw krakenftw commented Mar 20, 2025

…ponent

What does this PR do?

Visual Demo (For contributors especially)

Before -
image

After -
image

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

vercel bot commented Mar 20, 2025

@krakenftw is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Mar 20, 2025
@graphite-app graphite-app bot requested a review from a team March 20, 2025 16:46
@krakenftw krakenftw changed the title refactor: streamline DialogFooter structure in EditLocationDialog com… fix: layout of dialog (edit location) on bookings page Mar 20, 2025
Copy link

graphite-app bot commented Mar 20, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/20/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/20/25)

1 label was added to this PR based on Keith Williams's automation.

@retrogtx
Copy link
Contributor

hey @krakenftw a test is failing

@retrogtx
Copy link
Contributor

retrogtx commented Mar 21, 2025

Cant seem to commit to your PR

The test is just prettier failing, to fix it just run this in your terminal:

npx prettier --write \ apps/web/components/apps/AdditionalCalendarSelector.tsx \ apps/web/components/apps/AppPage.tsx \ apps/web/components/dialog/RerouteDialog.tsx \ apps/web/components/dialog/RescheduleDialog.tsx \ apps/web/components/getting-started/components/AppConnectionItem.tsx \ apps/web/components/getting-started/steps-views/ConnectCalendars.tsx \ apps/web/components/getting-started/steps-views/ConnectedVideoStep.tsx \ apps/web/components/getting-started/steps-views/SetupAvailability.tsx \ apps/web/components/getting-started/steps-views/UserSettings.tsx \ apps/web/components/security/DisableUserImpersonation.tsx \ apps/web/components/security/EnableTwoFactorModal.tsx \ apps/web/components/settings/platform/oauth-clients/OAuthClientCard.tsx \ apps/web/components/setup/EnterpriseLicense.tsx \ apps/web/components/ui/UsernameAvailability/UsernameTextfield.tsx \ apps/web/components/ui/form/DatePicker.tsx

And then push the changes!

@retrogtx retrogtx closed this Mar 21, 2025
@retrogtx retrogtx reopened this Mar 21, 2025
@github-actions github-actions bot added ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Mar 21, 2025
@krakenftw krakenftw requested a review from anikdhabal March 21, 2025 04:54
@krakenftw krakenftw requested a review from TusharBhatt1 March 21, 2025 11:10
@krakenftw krakenftw closed this Mar 24, 2025
@krakenftw krakenftw reopened this Mar 24, 2025
@krakenftw
Copy link
Contributor Author

@TusharBhatt1 @anikdhabal Anything left to merge here?

@retrogtx
Copy link
Contributor

lint failing

@krakenftw
Copy link
Contributor Author

@retrogtx I cant run the linting check (yarn lint) on my end, it also seems to be failing on the action? am i missing something

Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync ready-for-e2e 💻 refactor ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix layout for edit location dialog in bookings page
4 participants