Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow conferencing apps to be installed on teams #19784

Open
wants to merge 52 commits into
base: main
Choose a base branch
from

Conversation

SomayChauhan
Copy link
Member

@SomayChauhan SomayChauhan commented Mar 6, 2025

What does this PR do?

This PR enables conferencing apps to be installed on Teams, currently limited to Atoms only.

https://www.loom.com/share/00eff5f46219440babdb20ca78e2e692?sid=363bbd2b-94ba-42bd-a3b4-25e6d804d06e

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

⚠️ Note: needs publishing new version of platform-libraries.

#19784 (comment)

TODO - followups

  • make conferencing apps work for organizations.
  • Apply the team guards for stripe controllers when installing it on a team. Currently, anyone can install them—restrict this to admins and owners only. -- feat: add guards to stripe teams controller #20155
  • Extend conferencing app support to the main app (not just the platform). Update the app installation flow to allow installation at the team level, not just for individual users
  • Make team conferencing apps work with DWD

@SomayChauhan SomayChauhan requested review from a team as code owners March 6, 2025 10:10
@graphite-app graphite-app bot requested a review from a team March 6, 2025 10:10
@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Mar 6, 2025
@dosubot dosubot bot added teams area: teams, round robin, collective, managed event-types ✨ feature New feature or request labels Mar 6, 2025
Copy link
Contributor

github-actions bot commented Mar 20, 2025

E2E results are ready!

@SomayChauhan SomayChauhan enabled auto-merge (squash) March 21, 2025 13:41
ThyMinimalDev
ThyMinimalDev previously approved these changes Mar 21, 2025
@zomars zomars added the high-risk Requires approval by Foundation team label Mar 25, 2025
Copy link

socket-security bot commented Mar 27, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

@hbjORbj
Copy link
Contributor

hbjORbj commented Mar 28, 2025

@SomayChauhan Can you resolve conflicts? and we are good to go I think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only ✨ feature New feature or request high-risk Requires approval by Foundation team platform Anything related to our platform plan ready-for-e2e teams area: teams, round robin, collective, managed event-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants