perf: use nextjs i18n routing #19615
Draft
+1,159
−1,137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
dosubot
bot
added
i18n
|
TODO: Continue going top down from apps/[slug]/page |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/28/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (02/28/25)1 reviewer was added to this PR based on Keith Williams's automation. |
|
TODO: Continue going top down from /auth |
hbjORbj
force-pushed
the
perf/use-nextjs-i18n-routing
branch
from
e1d2bc7 to
34b4200
Compare
hbjORbj
commented
Feb 28, 2025
| optimizePackageImports: ["@calcom/ui"], | ||
| instrumentationHook: true, | ||
| serverActions: true, | ||
| }, | ||
| i18n: { |
There was a problem hiding this comment.
Not needed! — this was being ignored by app router anyways because app router doesn't support i18n config in next.config.js
hbjORbj
force-pushed
the
perf/use-nextjs-i18n-routing
branch
2 times, most recently
from
762caa3 to
c53b182
Compare
hbjORbj
force-pushed
the
perf/use-nextjs-i18n-routing
branch
from
c53b182 to
b712974
Compare
hbjORbj
commented
Mar 3, 2025
| @@ -164,7 +172,6 @@ export const config = { | |||
| // Next.js Doesn't support spread operator in config matcher, so, we must list all paths explicitly here. | |||
| // https://github.com/vercel/next.js/discussions/42458 | |||
| matcher: [ | |||
| "/", | |||
hbjORbj
commented
Mar 3, 2025
| fallbackLng: _nextI18Next?.userConfig?.i18n.defaultLocale, | ||
| }); | ||
| type LocaleType = keyof typeof dictionaries; | ||
| const translationCache = new Map<string, TFunction>(); |
hbjORbj
changed the title
hbjORbj
changed the title
eunjae-lee
reviewed
Mar 4, 2025
apps/web/app/[lang]/(use-page-wrapper)/(main-nav)/availability/page.tsx
Outdated
Show resolved
Hide resolved
eunjae-lee
reviewed
Mar 4, 2025
|
This PR is being marked as stale due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
next-i18nextand rather using Next.js routing-based i18n (ref: https://nextjs.org/docs/pages/building-your-application/routing/internationalization)[lang]directory/{locale}/...(browser URL stays the same and does NOT show the {locale})getTranslateutil (it now dynamically imports the translation json and returns it)generateMetadatautils to adapt to the changeIn #19638, we will remove
next-i18nextand replace all imports from it. I think we should merge this PR hand in hand with #19638Mandatory Tasks (DO NOT REMOVE)
How should this be tested?