Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce timeout to increase chances of retries #3717

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Reduce timeout to increase chances of retries #3717

merged 1 commit into from
Feb 19, 2025

Conversation

vevetron
Copy link
Contributor

Description

Reduce timeout to increase chances of retries.

Previously we had issues where node spin up was too long. But right now the errors are because we are attaching to the wrong node where our hdds are not located. This should make iterations faster for this error. A hacky band-aid if you will.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

not tested

Post-merge follow-ups

Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.

  • No action required
  • Actions required (specified below)

Copy link

The following changes will be applied to the production Kubernetes cluster upon merge.

BE AWARE this may not reveal changes that have been manually applied to the cluster getting undone—applying manual changes to the cluster should be avoided.

jupyterhub, hub, Deployment (apps) has changed:
...
          hub.jupyter.org/network-access-proxy-api: "true"
          hub.jupyter.org/network-access-proxy-http: "true"
          hub.jupyter.org/network-access-singleuser: "true"
        annotations:
          checksum/config-map: 3f4f09154ff91af7fc3c6ea6feccb144213f3e1470a55a578fb41c5f25499105
-         checksum/secret: 8dfd72a51b544878531b9972893dd6c99db993f988cc926aabab682bfcd5e49f
+         checksum/secret: f9fce65074ab7a96faea267a512e3f603e871ac554ff92d0e61a6e37b6dc6225
      spec:
        tolerations:
          - effect: NoSchedule
            key: hub.jupyter.org/dedicated
            operator: Equal
...
jupyterhub, hub, Secret (v1) has changed:
...
    name: hub
  data:
    hub.config.ConfigurableHTTPProxy.auth_token: 'REDACTED # (64 bytes)'
    hub.config.CryptKeeper.keys: 'REDACTED # (64 bytes)'
    hub.config.JupyterHub.cookie_secret: 'REDACTED # (64 bytes)'
-   values.yaml: '-------- # (12166 bytes)'
+   values.yaml: '++++++++ # (12165 bytes)'
  type: Opaque

@vevetron vevetron marked this pull request as ready for review February 19, 2025 20:18
@vevetron vevetron requested a review from evansiroky as a code owner February 19, 2025 20:18
@vevetron vevetron merged commit 09cb4a1 into main Feb 19, 2025
2 checks passed
@vevetron vevetron deleted the lower_timeout branch February 19, 2025 20:26
@edasmalchi edasmalchi self-requested a review February 19, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant