-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Terraform for production environment #3641
Conversation
a5c636b
to
92a91a6
Compare
531ad66
to
c9d50ce
Compare
Signed-off-by: Doc Ritezel <[email protected]>
08a7ab4
to
d78f252
Compare
d78f252
to
d55c8a9
Compare
Github workflows now use OIDC rather than pre-generated credentials https://docs.github.com/en/actions/security-for-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-google-cloud-platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of work!
We talked about the change in auth on a call (from github secrets to OpenID connect).
I can't analyze every line but checks are running good, let's give it a go!
Description
This adds an initial Terraform import from the terraformer tool.
Addresses [#3365]
Type of change
How has this been tested?
When running
make plan
in theiac/
directory, the infrastructure shows no differences.Some disk images related to jupyterhub have been excluded, as autoscaling continuously allocates new disk images.
Post-merge follow-ups
Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.