Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new profile to test a jupyterhub image #3614

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

vevetron
Copy link
Contributor

@vevetron vevetron commented Jan 7, 2025

Description

With this deployment, when using jupyterhub you should be able to select another image from the list. This image (2024.5.24) was created a while back.

Type of change

  • New feature

How has this been tested?

Has not been tested! Will go straight to production.

Post-merge follow-ups

  • No action required
  • Actions required (specified below)

Make sure jupyterhub is still functional

@vevetron vevetron requested a review from evansiroky as a code owner January 7, 2025 19:00
@vevetron vevetron requested review from themightychris and removed request for evansiroky January 7, 2025 19:00
Copy link

github-actions bot commented Jan 7, 2025

The following changes will be applied to the production Kubernetes cluster upon merge.

BE AWARE this may not reveal changes that have been manually applied to the cluster getting undone—applying manual changes to the cluster should be avoided.

jupyterhub, continuous-image-puller, DaemonSet (apps) has changed:
...
              - echo "Pulling complete"
            securityContext:
              allowPrivilegeEscalation: false
              runAsGroup: 65534
              runAsUser: 65534
+         - name: image-pull-singleuser-profilelist-2
+           image: map[name:ghcr.io/cal-itp/data-infra/jupyter-singleuser tag:2024.5.24]
+           command:
+             - /bin/sh
+             - -c
+             - echo "Pulling complete"
+           securityContext:
+             allowPrivilegeEscalation: false
+             runAsGroup: 65534
+             runAsUser: 65534
        containers:
          - name: pause
            image: registry.k8s.io/pause:3.9
            securityContext:
              allowPrivilegeEscalation: false
...
jupyterhub, hub, ConfigMap (v1) has changed:
...
          configuration item if not None
          """
          data = get_config(key)
          if data is not None:
              setattr(cparent, name, data)
-   checksum_hook-image-puller: "aec06d5f0e2841efa30b78d990d31ee065b97d0b449a525c1a5da336edec6687"
+   checksum_hook-image-puller: "e4c19a522db5261d6dd8a509b8678a795ac4d27da120f36f80fd99bfbd77b5be"
jupyterhub, hub, Deployment (apps) has changed:
...
          release: jupyterhub
          hub.jupyter.org/network-access-proxy-api: "true"
          hub.jupyter.org/network-access-proxy-http: "true"
          hub.jupyter.org/network-access-singleuser: "true"
        annotations:
-         checksum/config-map: ecf5268b9d342e8ab7c99ede7cbfde395133c574e9a4b24e25c2e825968e8311
-         checksum/secret: 748d3ab2f9a030f641afa2dd5145c08aeb19b9dd83c2ac9b7a4dbd5d5e6873e0
+         checksum/config-map: 4caea480dd83b11f0740df7b74391fe54d311bcf8ebf2b78b435ae7b6187bc6e
+         checksum/secret: 575940346b9c7439fd97115473ed32c772bde3185fbe26074c0b32f4a718bf75
      spec:
        tolerations:
          - effect: NoSchedule
            key: hub.jupyter.org/dedicated
            operator: Equal
...
jupyterhub, hub, Secret (v1) has changed:
...
    name: hub
  data:
    hub.config.ConfigurableHTTPProxy.auth_token: 'REDACTED # (64 bytes)'
    hub.config.CryptKeeper.keys: 'REDACTED # (64 bytes)'
    hub.config.JupyterHub.cookie_secret: 'REDACTED # (64 bytes)'
-   values.yaml: '-------- # (11559 bytes)'
+   values.yaml: '++++++++ # (11783 bytes)'
  type: Opaque

@erikamov erikamov merged commit 78338fd into main Jan 7, 2025
2 checks passed
@erikamov erikamov deleted the test_jupyterhub_images branch January 7, 2025 19:42
@vevetron
Copy link
Contributor Author

vevetron commented Jan 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants