Skip to content

remove unnecessary TaskListKind internal entity #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

remove unnecessary TaskListKind internal entity #1023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions src/main/java/com/uber/cadence/internal/worker/TaskListKind.java
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion src/main/java/com/uber/cadence/internal/worker/WorkflowPollTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import com.uber.cadence.PollForDecisionTaskResponse;
import com.uber.cadence.ServiceBusyError;
import com.uber.cadence.TaskList;
import com.uber.cadence.TaskListKind;
import com.uber.cadence.common.BinaryChecksum;
import com.uber.cadence.internal.metrics.MetricsTag;
import com.uber.cadence.internal.metrics.MetricsType;
Expand Down Expand Up @@ -73,7 +74,7 @@ public PollForDecisionTaskResponse poll() throws TException {
pollRequest.setIdentity(identity);
pollRequest.setBinaryChecksum(BinaryChecksum.getBinaryChecksum());

TaskList tl = new TaskList().setName(taskList).setKind(taskListKind.toThrift());
TaskList tl = new TaskList().setName(taskList).setKind(taskListKind);
pollRequest.setTaskList(tl);

if (log.isDebugEnabled()) {
Expand Down
1 change: 1 addition & 0 deletions src/main/java/com/uber/cadence/internal/worker/WorkflowPollTaskFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package com.uber.cadence.internal.worker;

import com.uber.cadence.PollForDecisionTaskResponse;
import com.uber.cadence.TaskListKind;
import com.uber.cadence.serviceclient.IWorkflowService;
import com.uber.m3.tally.Scope;
import java.util.Objects;
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/com/uber/cadence/internal/worker/WorkflowWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import com.uber.cadence.RespondDecisionTaskFailedRequest;
import com.uber.cadence.RespondQueryTaskCompletedRequest;
import com.uber.cadence.ScheduleActivityTaskDecisionAttributes;
import com.uber.cadence.TaskListKind;
import com.uber.cadence.WorkflowExecution;
import com.uber.cadence.WorkflowExecutionStartedEventAttributes;
import com.uber.cadence.WorkflowQuery;
Expand Down Expand Up @@ -107,7 +108,7 @@ public void start() {
service,
domain,
taskList,
TaskListKind.TASK_LIST_KIND_NORMAL,
TaskListKind.NORMAL,
options.getMetricsScope(),
options.getIdentity()),
pollTaskExecutor,
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/com/uber/cadence/worker/WorkerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import com.google.common.base.Preconditions;
import com.google.common.base.Strings;
import com.uber.cadence.PollForDecisionTaskResponse;
import com.uber.cadence.TaskListKind;
import com.uber.cadence.client.WorkflowClient;
import com.uber.cadence.converter.DataConverter;
import com.uber.cadence.converter.JsonDataConverter;
Expand Down Expand Up @@ -134,7 +135,7 @@ public WorkerFactory(WorkflowClient workflowClient, WorkerFactoryOptions factory
workflowClient.getService(),
workflowClient.getOptions().getDomain(),
getStickyTaskListName(),
TaskListKind.TASK_LIST_KIND_STICKY,
TaskListKind.STICKY,
stickyScope,
workflowClient.getOptions().getIdentity())
.get(),
Expand Down
32 changes: 0 additions & 32 deletions src/test/java/com/uber/cadence/internal/worker/TaskListKindTest.java
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/test/java/com/uber/cadence/internal/worker/WorkflowPollTaskTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public void setup() {
mockService,
"test-domain",
"test-taskList",
TaskListKind.TASK_LIST_KIND_NORMAL,
TaskListKind.NORMAL,
mockMetricScope,
"test-identity");
}
Expand Down