-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add clutches. #4787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.19.4
Are you sure you want to change the base?
Add clutches. #4787
Conversation
Hey! Maybe I can get to work on a UI? I was working on a swarm feature for Baritone and I think I have a good understanding of the codebase. Or maybe if there are any other features you'd like help with first? |
@ItsAGamer214 If you want to contribute to the repository, open up an issue. From there you can create a draft PR, commit to it, open it for review, and get it merged. A UI isn't in the scope of this specific issue but if you want to make one, feel free to do so. If you want to work on another thing instead, we have like 800 issues open (some are just trolls and others make no sense but there are still good ones that could be worked on). |
…stract class. Also rework logic.
…his also paves the way to bed clutches with the multiple types of beds involved.
…to not place on bottom.
…ariables needed and move clutches to a separate folder to avoid crowdedness.
I changed the swapped slot from the 8th hotbar slot to the currently selected one but I don't know if this is okay. I guess if it's not we should at least have a setting for which slot to switch to. |
Clutches that don't nullify fall damage only happen when the height multiplied by the percent of fall damage taken is equal to or below |
src/main/java/baritone/pathing/movement/movements/MovementDescend.java
Outdated
Show resolved
Hide resolved
src/main/java/baritone/pathing/movement/movements/MovementDescend.java
Outdated
Show resolved
Hide resolved
can i see a screen recording? |
src/main/java/baritone/pathing/movement/movements/MovementDescend.java
Outdated
Show resolved
Hide resolved
2025-09-11.20-15-33.mp42025-09-11.20-26-23.mp4Sorry for low quality. Ran these through a compressor at least twice for them to fit in 10mb limit. |
That looks... alright. It shouldn't recompute the path upon landing though? And maybe I'm being biased by the view snapping, but, the falling looks less controlled than before? Although, it doesn't look like you touched that part of the code... If you put lava around the column you're falling in, meaning you walk off a ledge and fall through a 1 block column with lava on all 3 sides, does it fall straight through without catching fire? Like if it bounces on a slime block is that bounce controlled enough to not hit the walls? |
It might just be the resolution. I found no issues with it missing the target in any of my testing or even developing. 2025-09-11.21-24-17.mp4 |
No idea why it's doing that but it isn't something I changed. (I think) Looking at the video, it only does that once. The only thing I would be able to think of is that it wasn't on the ground when it calculated but that can't be true since I added in a check to prevent that. I guess its current path just didn't work out? |
@leijurv Only other thing I can think of is that the code doesn't like that it's in the twisting vines? I don't know how to check this though. It also doesn't recalculate every time it does a twisting vine clutch so idrk. |
Remove debug print statement from isFinished method.
@ZacSharp Does this look good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed hasClutched
and replaced it with a check to see if it's touching ground and I think that broke cobwebs since the bot waits until it is on the ground to start moving again. I'll fix it when I got time.
@leijurv I can't reproduce the path recalculation anymore, so that might be gone. The bot is still trying to break cobwebs instead of just going through them which is kinda annoying. IDK how to fix that though. Any ideas? |
Closes #3226
Closes #4548 (duplicate)
Closes #92
Closes #2907
Closes #2975
Closes #4146
Closes #1698
Closes #1146
Closes #1018
Closes #3950 (duplicate)
Closes #109 (Still can't reproduce. I think this issue is gone now)
Closes #28 (Doesn't clutch if there's something like a torch in the way)
Just a few more clutches to Baritone.
damage when there's a carpet on top of them. This includes slime blocks and powdered snow)
- [ ] Boat (An entity... might be difficult. A good thing about this is that you don't need to be directly under it, you just need the ability to right click on it) (Also has a bunch of variants) (Also has the chest boats)- [ ] Minecart (A little more complicated since you also need to place a rail if there isn't one already)- [ ] Horse (Same as boat but we need to check if it's tamed or not since untamed horses require you to have nothing in your hand to mount while tamed horses just don't care)- [ ] Strider (Would need to check if it has a saddle already on it. If it does, just mount. If it doesn't, check if we have a saddle and if we do, place the saddle then mount)- [ ] Donkey (Same has horse)- [ ] Mule (Same as horse)- [ ] Pig (Same as strider)- [ ] Items (Picking up a water bucket for example and then placing it)I might've missed a few things so let me know if there's anything else. I would say camels but they aren't in 1.19.4.
With water, we should be checking to make sure we aren't placing on something that wouldn't stop our fall and just waterlog the block. These include leaves, mangrove roots, top slabs, etc.-DoneAlso also with ladders and vines, we should be checking if there is a block north, south, east, or west of the ladder or vine being placed since it won't place otherwise.-DoneShould we be adding a setting for every single new clutch? Baritone's settings are already impossible to navigate in-game (we desperately need a UI) so doing this won't exactly help with that issue.-NoIf the item to clutch with is in the inventory instead of the hotbar, the bot just acts like it isn't there. Even when-FixedallowInventory
is on.Maybe have a setting that breaks the block you clutched on after the clutch is done. Would need to adjust costs for this. This setting should also control picking up with a bucket.-New setting not needed sinceallowBreak
Even if the block is waterloggable, if we can still be inside that water (ex. half slab), it should be allowed. An even more complicated version of this would be clutching on the parts of stairs that are waterlogged. There would need to be air/other stairs facing the opposite direction/slabs around them so we can lose the 0.5 blocks to hit the water. This is too hard though so I'm not going to bother.-DoneAlso I guess if we fall in water that's already there and we have a bucket, we shouldn't try to pick it back up again.-Done