Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 fix blackWhiteList feature #40

Merged
merged 3 commits into from
Nov 15, 2024
Merged

🔨 fix blackWhiteList feature #40

merged 3 commits into from
Nov 15, 2024

Conversation

pape07
Copy link

@pape07 pape07 commented Oct 24, 2024

Sans ce changement les nouveaux projects ne sont jamais créés si au moins un projet est présent dans le blacklist et que la fonctionnalité whitelist n'est pas activée

@pape07 pape07 self-assigned this Oct 24, 2024
@pape07 pape07 requested a review from evrardjp October 24, 2024 14:44
@pape07
Copy link
Author

pape07 commented Oct 24, 2024

@Whisper40 peux tu mettre le retour de tes tests

Copy link
Contributor

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it works/could work, I am not seeing everything that can prove it: No tests.

Please add a unit test, covering all 3 cases mentioned here (possibly more with fuzzing).

Sans ce changement les nouveaux projects ne sont jamais créés si au moins un projet est présent dans le blacklist et que la fonctionnalité whitelist n'est pas activée
@pape07 pape07 force-pushed the fixBlackWhiteList_1.28 branch from 1688468 to 37af7d5 Compare October 28, 2024 13:49
@pape07 pape07 force-pushed the fixBlackWhiteList_1.28 branch 4 times, most recently from 99e563c to 65bd6be Compare November 14, 2024 10:57
@pape07 pape07 force-pushed the fixBlackWhiteList_1.28 branch from 65bd6be to 4e0e4fb Compare November 14, 2024 11:47
Copy link
Contributor

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test the change. But at first sight, it looks okay.

I will approve, but I would like to see a follow up commit for two reasons:

  1. The tests are hard to read or lie a bit.
  2. Plenty of nits.

@pape07 pape07 force-pushed the fixBlackWhiteList_1.28 branch from fb308fd to 908d722 Compare November 15, 2024 16:48
vu que nous avons adapter la fonction sur le précédent commit pour qu'il soit mieux testable, nous modifions ici les tests unitaires de la fonctions GenerateProject
@pape07 pape07 force-pushed the fixBlackWhiteList_1.28 branch from 908d722 to 0073ab6 Compare November 15, 2024 17:42
Copy link
Contributor

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not tested but lgtm

@evrardjp evrardjp merged commit a26eb95 into master Nov 15, 2024
3 checks passed
@evrardjp evrardjp deleted the fixBlackWhiteList_1.28 branch November 15, 2024 17:44
@evrardjp evrardjp restored the fixBlackWhiteList_1.28 branch November 15, 2024 17:46
@evrardjp evrardjp deleted the fixBlackWhiteList_1.28 branch November 19, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants